kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.62k stars 1.63k forks source link

[frontend] The UI does not account for the `artifact-repositories` configmap #11339

Closed droctothorpe closed 2 days ago

droctothorpe commented 3 weeks ago

We contributed https://github.com/kubeflow/pipelines/pull/11010 in August to resolve a frontend bug where component logs were no longer accessible after pods and Argo workflows were GCed. This PR solved the problem for the overwhelming majority of use cases, but we discovered a corner case that it doesn't account for.

Specifically, AWF supports dynamic key prefixes that vary on a per namespace basis using the namespaced artifact-repositories configmap. Additional information about that model is available here.

To support this pattern, we want to extend createPodLogsMinioRequestConfig to call a standalone function that gets the configmap and extracts the keyPrefix field.

It will be decomposed, narrowly scoped, and disabled by default. Users who leverage namespace-scoped key prefixes can toggle it on with an environment variable or by modifying config.ts.

We plan to start working on this soon. Please let us know if there are any objections to the proposed design. Thank you!

cc @zijianjoy


Impacted by this bug? Give it a 👍.