kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.62k stars 1.63k forks source link

chore: Update the generated cache proto file #11359

Closed rimolive closed 2 weeks ago

rimolive commented 2 weeks ago

Description of your changes: Update the cache proto file to 1.33 to keep all IR proto files in the same version.

Checklist:

gregsheremeta commented 2 weeks ago

mind changing the commit and PR messaged to say specifically that we're only re-generating cache_key? thanks!

HumairAK commented 2 weeks ago

for additional context this is just resolving the diff after running make golang, i.e. the protogen version being used in the api-generator image.

/lgtm /approve

HumairAK commented 2 weeks ago

/hold

gregsheremeta commented 2 weeks ago

/unhold /lgtm /approve

thanks!

google-oss-prow[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gregsheremeta, HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[api/OWNERS](https://github.com/kubeflow/pipelines/blob/master/api/OWNERS)~~ [HumairAK] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment