test: Added support for Python 3.13 to tests

kubeflow / pipelines

Machine Learning Pipelines for Kubeflow

https://www.kubeflow.org/docs/components/pipelines/

Apache License 2.0

3.62k stars 1.63k forks source link

test: Added support for Python 3.13 to tests #11376

Closed hbelmiro closed 3 days ago

hbelmiro commented 1 week ago

Description of your changes: This PR adds support for Python 3.13 to tests. This is a follow-up for https://github.com/kubeflow/pipelines/pull/11372

Checklist:

[x] You have signed off your commits
[x] The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

google-oss-prow[bot] commented 1 week ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

hbelmiro commented 1 week ago

@chensun we have several tests failing with Python 3.13. Can you please take a look? Also, I think we should have all tests using at least the minor and major supported Python versions (3.9 and 3.13).

cc @DharmitD @HumairAK

chensun commented 1 week ago

@chensun we have several tests failing with Python 3.13. Can you please take a look?

From SDK side, kfp-pipeline-spec is blocking Python 3.13 support. I sent a PR: https://github.com/kubeflow/pipelines/pull/11378, PTAL.

Also, I think we should have all tests using at least the minor and major supported Python versions (3.9 and 3.13).

No, I think it would be unnecessary and waste of resource to run all e2e or backend-integration tests with different Python versions. If we think SDK's main role as a YAML generator, as long as the produced YAML file doesn't change across Python versions--the SDK unit test guarantees that--they would work on the backend.

hbelmiro commented 3 days ago

@chensun I reverted the changes to add 3.13 to all tests and left 3.13 only on those tests that use all Python versions. Can you please review?

google-oss-prow[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[.github/OWNERS](https://github.com/kubeflow/pipelines/blob/master/.github/OWNERS)~~ [chensun] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment