kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.62k stars 1.63k forks source link

fix(sdk): Backport fixes in kubeflow/pipelines#11075 #11392

Open rimolive opened 6 days ago

rimolive commented 6 days ago

Introduced back the functions to convert k8s size values to float, but moved to kfp.dsl.utils

Description of your changes: fixes #11390

Checklist:

google-oss-prow[bot] commented 6 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[sdk/OWNERS](https://github.com/kubeflow/pipelines/blob/master/sdk/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
HumairAK commented 1 day ago

Thanks @rimolive can you also add this change to: https://github.com/kubeflow/pipelines/blob/master/sdk/RELEASE.md#bug-fixes-and-other-changes? otherwise lgtm