search

kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.61k stars 1.63k forks source link

Fix the component tests with the yaml reference in the samples #1758

Closed gaoning777 closed 4 years ago

gaoning777 commented 5 years ago

The component test infra replaces the image tag with the new ones from the cloudbuild. Since now we use the yaml reference instead of the image tag, the component tests need to be fixed to accommodate the change.

paveldournov commented 5 years ago

@gaoning777 are the test broken now or this makes the maintenance harder?

gaoning777 commented 5 years ago

The component integration tests are broken. However, The purpose of the component tests is to catch the component errors early. The release is not blocked since the sample tests are run when the PR to release the components are merged.

Ark-kun commented 5 years ago

The component test infra replaces the image tag with the new ones from the cloudbuild. Since now we use the yaml reference instead of the image tag, the component tests need to be fixed to accommodate the change.

Sample tests replace the image names in the final compiled Argo workflow yaml, so they are replaced regardless of whether or not the component was loaded from component.yaml.

We need to check whether the postsubmit tests actually replace any image.

Ark-kun commented 5 years ago

AFAIK this is fixed. The postsubmit tests build the new component images, compile the samples and replace the images inside the compiled workflows. @numerology can you confirm?

numerology commented 5 years ago

AFAIK this is fixed. The postsubmit tests build the new component images, compile the samples and replace the images inside the compiled workflows. @numerology can you confirm?

Currently in the post-submit test we only have XGboost sample test, whose images are replaced by the latest cloud build tag versions. It works fine.

However I agree that if we would like to add more to the post-submit test it won't be very manageable. Need a better way to specify the image version used in post-submit tests.

Ark-kun commented 5 years ago

@gaoning777 WDYT?

numerology commented 4 years ago

/close

Let's fix this right now because the tests are okay right now.

k8s-ci-robot commented 4 years ago

@numerology: Closing this issue.

In response to [this](https://github.com/kubeflow/pipelines/issues/1758#issuecomment-571378818): >/close > >Let's fix this right now because the tests are okay right now. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.