search

kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.61k stars 1.63k forks source link

Possible inconsistent experiment name in sample test. #2110

Closed numerology closed 5 years ago

numerology commented 5 years ago

Currently, it is possible for a user to upload a notebook sample with hard-coded arbitrary experiment name to run their pipeline. However, our sample test infra adopts the convention that the experiment name should be TEST_NAME-test, which might be inconsistent with the user specified name.

Inconsistent names can cause the sample test infra fails to capture the test run result.

numerology commented 5 years ago

/close Fixed by #2292 . Now sample test infra can override experiment name through env var.

k8s-ci-robot commented 5 years ago

@numerology: Closing this issue.

In response to [this](https://github.com/kubeflow/pipelines/issues/2110#issuecomment-543480309): >/close >Fixed by #2292 . >Now sample test infra can override experiment name through env var. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.