kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.61k stars 1.63k forks source link

[SDK] Container builder should allow secret configuration #2702

Closed Bobgy closed 4 years ago

Bobgy commented 4 years ago

Discussed in https://github.com/kubeflow/pipelines/pull/2619#issuecomment-562236972

When we want support to all types of authentication:

Container builder (for lightweight python component) should allow secret configuration to not set user-gcp-sa secret as a configuration from SDK.

/assign @gaoning777 /kind feature /priority p2 Note priority is p2 because after the change in https://github.com/kubeflow/pipelines/pull/2619, only outside of GCP clusters need this. We don't yet support them well now.

gaoning777 commented 4 years ago

/assign @numerology let me know if you need any clarifications. /unassign @gaoning777

Bobgy commented 4 years ago

/cc @Ark-kun /priority p1

Bump priority because this is a feature regression.

Bobgy commented 4 years ago

Moving this to post 1.0, because there hasn't been any requests. I think we can focus on workload identity support for now

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 4 years ago

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.