kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.63k stars 1.64k forks source link

[MKP] Broken bucket name with managed storage: `'%!s(<nil>)-kubeflow-pipelines` #3797

Open Ark-kun opened 4 years ago

Ark-kun commented 4 years ago

The issue occurs when you check the "Managed storage" checkbox and just click Deploy.

I expect that the bucket name should be always correct.

workflow-controller-configmap:

{
namespace: default,
executorImage: gcr.io/cloud-marketplace/google-cloud-ai-platform/kubeflow-pipelines/argoexecutor:0.5.1,
artifactRepository:
{
    s3: {
        bucket: '%!s(<nil>)-kubeflow-pipelines-0-5-1',
        keyPrefix: artifacts,
        endpoint: minio-service.default:9000,
        insecure: true,
        accessKeySecret: {
            name: mlpipeline-minio-artifact,
            key: accesskey
        },
        secretKeySecret: {
            name: mlpipeline-minio-artifact,
            key: secretkey
        }
    },
    archiveLogs: true
}
}

The gcp-default-config configMap seems to have correct information.

kubeflow-pipelines-0-5-1-deployer-config: values.yaml:

__image_repo_prefix__: gcr.io/cloud-marketplace/google-cloud-ai-platform/kubeflow-pipelines
name: kubeflow-pipelines-0-5-1
namespace: default
managedstorage.enabled: true
rmgogogo commented 4 years ago

"check the "Managed storage" checkbox and just click Deploy."

Do you mean without fill the CloudSQL instance name? It's expected error if so.

The UI is driven by schema.yaml defined by MKP team. We can't do flexible check there.

Maybe we handle this together with the PR you send which uses CloudSQL instance name to check the input.

https://github.com/kubeflow/pipelines/pull/3800 (I will provide few comment to this PR to continue the discussion).

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 4 years ago

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

Ark-kun commented 4 years ago

/frozen

Ark-kun commented 4 years ago

/frozen