kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.6k stars 1.62k forks source link

Missing Markdown support: horizontal rule, emojis #5512

Closed jackwhelpton closed 3 months ago

jackwhelpton commented 3 years ago

Environment

Steps to reproduce

Output a markdown artifact containing the missing features: a horizontal rule, and an emoji, e.g. :warning:

        metadata = {
          "outputs": [
          {
            "storage": "inline",
            "source": "line1\n---\n:warning: Item had multiple genre labels",
            "type": "markdown",
          }]
        }

Expected result

The Visualizations tab and Run output should render the horizontal rule and emoji:

line1

⚠ī¸ Item had multiple genre labels

Instead, the original markup code is visible:

line1 --- :warning: Item had multiple genre labels


Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

jackwhelpton commented 3 years ago

As a workaround, using the character ⚠ī¸ directly works; this doesn't help with, for example, ℹī¸ (:information_source:).

This doesn't help with the horizontal rule, either.

jackwhelpton commented 3 years ago

I'm expanding this ticket as I find other missing markdown features: let me know if each one should be spun off as a separate ticket.

zijianjoy commented 3 years ago

Hello @jackwhelpton , feel free to add more missing markdown features in this ticket. We can update the issue description to match the scope as well. Ideally we should use another markdown render which can fit all markdown feature requests.

https://github.com/kubeflow/pipelines/blob/226079338b38b85ae3b63a5e289c6ca0cd9511d0/frontend/src/components/viewers/MarkdownViewer.tsx#L111-L114

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 4 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 3 months ago

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.