search

kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.55k stars 1.6k forks source link

[backend] column name same with reserved keyword of mysql 8.0 #5893

Closed algs closed 5 months ago

algs commented 3 years ago

Environment

Steps to reproduce

When creating table in mysql 8.0, it would report fail because there are columns name Description in tables experiments, jobs, pipelines, run_details, which is the reserved keyword of mysql

Expected result

Creating tables without error.

Shall we use Descriptions as the columns' name?

Materials and Reference

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

cc @Jeffwan

Bobgy commented 3 years ago

https://dev.mysql.com/doc/refman/8.0/en/keywords.html It says description is a nonreserved keyword, am I missing anything?

Welcome contribution if anyone figures out how to deploy KFP with mysql 8.0

algs commented 3 years ago

https://dev.mysql.com/doc/refman/8.0/en/keywords.html It says description is a nonreserved keyword, am I missing anything?

Welcome contribution if anyone figures out how to deploy KFP with mysql 8.0

It's been covered in MySQL 8.0 New Keywords and Reserved Words

NikeNano commented 3 years ago

I have tried it out with MySQL 8 and got it working, some very minor things needed to change. I can make a PR with it, could you point me to how we build the images for gcr @Bobgy?

As @Bobgy points out description is a non-reserved keyword:

DESCRIPTION; added in 8.0.4 (nonreserved)

and 

Nonreserved keywords are permitted as identifiers without quoting. Reserved words are permitted as identifiers if you quote them as ...

Source: https://dev.mysql.com/doc/refman/8.0/en/keywords.html#keywords-new-in-current-series. Maybe you could try to check out the branch @algs and see if it work for you? Let me know if you have any questions so I can help out.

Bobgy commented 3 years ago

Access to gcr is restricted to admins. I can help you upload : )

sidpalas commented 3 years ago

FWIW, I have successfully deployed KFP 1.5.0 on GKE with MySQL 8 running in CloudSQL.

I haven't done much testing yet but was able to successfully run some pipelines and store the associated data.

NikeNano commented 3 years ago

FWIW, I have successfully deployed KFP 1.5.0 on GKE with MySQL 8 running in CloudSQL.

I haven't done much testing yet but was able to successfully run some pipelines and store the associated data.

Awesome, let me know if you get some issues @sidpalas!

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

rimolive commented 5 months ago

Closing this issue as it seems fixed.

/close

google-oss-prow[bot] commented 5 months ago

@rimolive: Closing this issue.

In response to [this](https://github.com/kubeflow/pipelines/issues/5893#issuecomment-1996168100): >Closing this issue as it seems fixed. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.