[bug] Sanitize Names kfp.dsl doesn't allow the usage of argo template variables - Githubissues

kubeflow / pipelines

Machine Learning Pipelines for Kubeflow

https://www.kubeflow.org/docs/components/pipelines/

Apache License 2.0

3.6k stars 1.62k forks source link

[bug] Sanitize Names kfp.dsl doesn't allow the usage of argo template variables #6559

Closed munagekar closed 4 months ago

munagekar commented 3 years ago

What steps did you take

Named a k8s resource asxxx-{{workflow.uid}}. It got converted to xxx-workflow-uid. This breaks argo workflow templating.

https://github.com/kubeflow/pipelines/blob/5d82fa7dc8dfe381a8759358b92cc94ef0a0f137/sdk/python/kfp/compiler/_k8s_helper.py#L20-L37.

What did you expect to happen:

k8s resource names should allow argo workflow templating.

Anything else you would like to add:

{{.+}} should be considered a special case and should not be affected by name sanitization.

Labels

/area sdk

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

chensun commented 3 years ago

@munagekar, For my education, what's your use case to include Argo placeholders in some "name"?

munagekar commented 3 years ago

@chensun

prefix multiple resources created(svc,pvc,depolyment associated with a workflow ) with {{workflow.name}} to link all relevant resources together.
avoid a resource-name-conflict if the same pipeline is executed twice simultaneously by making the name dependent on unique-id associated with the workflow.
previously this also prevented caching with VolumeOp by making the name unique. REF

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 4 months ago

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.