kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.55k stars 1.6k forks source link

[frontend] Inaccurate two-level dropdown selection #8133

Closed zpChris closed 4 months ago

zpChris commented 2 years ago

Environment

Kubeflow Pipelines Standalone

2.0.0-alpha.3

Steps to reproduce

  1. Create a run which has two Confusion Matrix artifacts of the same type on the same execution
    • One artifact has the name Artifact ID #<id>, and the other artifact has no name but an ID of <id>
    • These confusion matrices should be different
    • Note: This may be difficult to accomplish, and is not presented here, but the issue is shown by understanding the underlying code and implementation.
  2. Go to the "Runs" tab on KFP
  3. Select that run and one other, and click "Compare Runs"
  4. Select the "Confusion Matrix" tab under "Metrics"
  5. Select both confusion matrices and view the compare results

Expected result

The Confusion Matrices should be displayed as expected, but instead one of the confusion matrices will be shown twice.

Materials and Reference

On the two-panel layout for Confusion Matrices, HTML, and Markdown, we need to improve the differentiation between display name and ID, likely by adding an underlying value to each dropdown item (rather than requiring each name be unique).

This is mentioned in this GitHub discussion; essentially, if an Execution has a displayName of exact value “Execution ID #1” and another Execution has no displayName but has an ID of 1, we run into mis-identified artifacts and dropdown items due to the logic implemented at getLinkedArtifactFromSelectedItem.


Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

github-actions[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 4 months ago

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.