search

kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
307 stars 143 forks source link

Use multi-stage build for pytorch operator Dockerfile #195

Closed hmtai closed 5 years ago

hmtai commented 5 years ago

Now when user build pytorch operator image,he need build the pytorch operator binary first then use the Dockerfile to build the image.

Actually this can be built with docker multi-stage build to build the image only in one docker file.

gaocegege commented 5 years ago

Yeah, I think so.

/cc @johnugeorge

BTW, we should do it for tf-operator, too.

@hmtai Are you interested in the issue? I'd appreciate if you could help us.

gaocegege commented 5 years ago

/kind feature

johnugeorge commented 5 years ago

Closing the issue as PR is merge /close

k8s-ci-robot commented 5 years ago

@johnugeorge: Closing this issue.

In response to [this](https://github.com/kubeflow/pytorch-operator/issues/195#issuecomment-526072984): >Closing the issue as PR is merge >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.