Update manifest to latest

kubeflow / pytorch-operator

PyTorch on Kubernetes

Apache License 2.0

307 stars 143 forks source link

Update manifest to latest #199

Closed hougangliu closed 5 years ago

hougangliu commented 5 years ago

Update manifest to latest, making easy to test or develop pytorch-operator

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign richardsliu You can assign the PR to them by writing /assign @richardsliu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

coveralls commented 5 years ago

Coverage remained the same at 85.281% when pulling cd780b90b4329486475d4b5c68e543f1a4b0c47a on hougangliu:fix-clusterrole into ca2c9c4be35c065f1eec6a63e2d38e29a2c07efc on kubeflow:master.

johnugeorge commented 5 years ago

@hougangliu I can ask someone to create a v1.0 tag for the image. I will update it here once done

hougangliu commented 5 years ago

@hougangliu I can ask someone to create a v1.0 tag for the image. I will update it here once done

cool. Close this PR now

johnugeorge commented 5 years ago

I meant, we can use 1.0 tag for the pytorch operator in the manifests(instead of rc image) when created. We can use this same PR for updating the manifests

hougangliu commented 5 years ago

ok, I will re-create the PR with 1.0 tag