search

kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
307 stars 143 forks source link

Add controller-name label for Pods and services #211

Closed johnugeorge closed 5 years ago

johnugeorge commented 5 years ago

Since job label is renamed to common label 'job-name', controller-name is required for pods and services to distinguish the operator.

Related: https://github.com/kubeflow/tf-operator/issues/1066

johnugeorge commented 5 years ago

/area 0.7.0

gaocegege commented 5 years ago

We can refer to https://github.com/kubeflow/tf-operator/pull/1067/files

johnugeorge commented 5 years ago

Yes. /assign

johnugeorge commented 5 years ago

Merged as part of https://github.com/kubeflow/pytorch-operator/pull/212

johnugeorge commented 5 years ago

Closing this issue /close

k8s-ci-robot commented 5 years ago

@johnugeorge: Closing this issue.

In response to [this](https://github.com/kubeflow/pytorch-operator/issues/211#issuecomment-527813063): >Closing this issue >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.