kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
306 stars 143 forks source link

Add mnist sample dockerfile for ppc64le #217

Closed zheddie closed 5 years ago

zheddie commented 5 years ago

/cc @jinchihe @hougangliu

Please help to review and merge. thanks.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign johnugeorge You can assign the PR to them by writing /assign @johnugeorge in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 5 years ago

Hi @zheddie. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
hougangliu commented 5 years ago

/ok-to-test

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 85.345% when pulling 123c85603f2ba99720a0d781d22676685dd40fe0 on zheddie:master into dfbbc1882d178ee99008fc838dabc576ff708d40 on kubeflow:master.

jinchihe commented 5 years ago

@zheddie Pls assign CLA following above description, thanks.

zheddie commented 5 years ago

@googlebot I signed it!

zheddie commented 5 years ago

@googlebot I signed it!

zheddie commented 5 years ago

@googlebot I signed it!

googlebot commented 5 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

zheddie commented 5 years ago

@googlebot I fixed it!

zheddie commented 5 years ago

@googlebot I signed it!

zheddie commented 5 years ago

@googlebot I fixed it!

zheddie commented 5 years ago

@googlebot I fixed it!

zheddie commented 5 years ago

@googlebot I fixed it!

zheddie commented 5 years ago

@googlebot I signed it!

jinchihe commented 5 years ago

@zheddie pls check why the checkin user is "root"?

root authored and root committed
gaocegege commented 5 years ago

@ziamsyed Please configure your git config user.name and user.email locally. It shows that it is not configured properly.

zheddie commented 5 years ago

Using a wrong username by mistake. Closing it .