search

kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
306 stars 143 forks source link

add mnist example dockerfile for ppc64le #218

Closed zheddie closed 5 years ago

zheddie commented 5 years ago

/cc @jinchihe @hougangliu I corrected the username issue. Please help to review this request. thanks.

k8s-ci-robot commented 5 years ago

Hi @zheddie. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jinchihe commented 5 years ago

/ok-to-test

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 85.345% when pulling e9e68fdab1249048c17365d4dfbbe3185ce4b0b8 on zheddie:master into dfbbc1882d178ee99008fc838dabc576ff708d40 on kubeflow:master.

gaocegege commented 5 years ago

Thanks for your contribution! :tada: :+1:

Do you have plan to add doc about it in https://github.com/kubeflow/pytorch-operator/blob/master/examples/mnist/README.md?

johnugeorge commented 5 years ago

@zheddie

jinchihe commented 5 years ago

@zheddie Could you please also update Readme file as @gaocegege commented? Thanks.

zheddie commented 5 years ago

@jinchihe @gaocegege , README.md was updated , please help to review. Thanks.

hougangliu commented 5 years ago

/lgtm Thanks

hougangliu commented 5 years ago

/cc @johnugeorge @gaocegege

johnugeorge commented 5 years ago

/lgtm

johnugeorge commented 5 years ago

/approve

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)~~ [johnugeorge] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment