search

kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
306 stars 143 forks source link

feat: Replace common with kubeflow/common #225

Closed gaocegege closed 4 years ago

gaocegege commented 4 years ago

Ref https://github.com/kubeflow/tf-operator/issues/1087

gaocegege commented 4 years ago

/hold

Hold until tf-operator merged.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 85.345% when pulling b8b848d65bf9c92806481f33145bd78555fc99ea on gaocegege:common into b32d658d5c63b1ec2d115fc5a4734149f43108da on kubeflow:master.

gaocegege commented 4 years ago

/hold cancel

/assign @johnugeorge

johnugeorge commented 4 years ago

/lgtm /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)~~ [johnugeorge] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment