search

kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
306 stars 143 forks source link

Generate Kubeflow PyTorchJob SDK #227

Closed jinchihe closed 4 years ago

jinchihe commented 4 years ago

Discussed in https://github.com/kubeflow/tf-operator/issues/167, and requried by @johnugeorge.

The PR is includes:

Next:

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-62.4%) to 22.97% when pulling 1a30426c849d1693fcf8d179e2c2a26ee9ee2343 on jinchihe:generate_sdk into 5522f9144268e2495a924d24647b4a2d9b63eaae on kubeflow:master.

jinchihe commented 4 years ago

Failed to set kubeflow in CI test.

level=error msg="validating registry URL: validating GitHub registry URL: \"https://github.com/kubeflow/kubeflow/tree/master/kubeflow/reg
istry.yaml\" actual 404; expected 200"

Seems this caused by https://github.com/kubeflow/kubeflow/pull/4484, the ksonnet registry has been removed, we need to enhance this.

jinchihe commented 4 years ago

/assign @johnugeorge @gaocegege /cc @animeshsingh @richardsliu @jlewi

The PR is ready for reviewing now, please see the PR description section for details. Thanks a lot!

johnugeorge commented 4 years ago

Looks great. Thanks @jinchihe for this contribution

johnugeorge commented 4 years ago

/lgtm /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)~~ [johnugeorge] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment