kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
306 stars 143 forks source link

fix(job_test) test case should not include worker service #231

Closed leileiwan closed 4 years ago

leileiwan commented 4 years ago

hi, the code fix the issue https://github.com/kubeflow/pytorch-operator/issues/228

k8s-ci-robot commented 4 years ago

Hi @leileiwan. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
leileiwan commented 4 years ago

/assign @richardsliu

johnugeorge commented 4 years ago

/ok-to-test

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 85.345% when pulling 22ea5ea03043dc4c827e0da72cbee63d549ae0a9 on leileiwan:master into 5522f9144268e2495a924d24647b4a2d9b63eaae on kubeflow:master.

johnugeorge commented 4 years ago

can you do a rebase?

gaocegege commented 4 years ago

/lgtm

Thanks for your contribution! :tada: :+1:

Waiting for johnu's approval.

johnugeorge commented 4 years ago

Thanks for your contribution. /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)~~ [johnugeorge] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment