search

kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
307 stars 143 forks source link

feat(deletePodsAndServices):only delete master service #233

Closed leileiwan closed 4 years ago

leileiwan commented 4 years ago

for issue https://github.com/kubeflow/pytorch-operator/issues/232

k8s-ci-robot commented 4 years ago

Hi @leileiwan. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
leileiwan commented 4 years ago

/assign @johnugeorge

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 22.97% when pulling 330317135622ea58bba736bd6f427ba8b0eff890 on leileiwan:master into c05874c7d4c078f32099b4729b380b97755e2b21 on kubeflow:master.

johnugeorge commented 4 years ago

/ok-to-test

gaocegege commented 4 years ago

/lgtm /assign @johnugeorge

johnugeorge commented 4 years ago

/approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)~~ [johnugeorge] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment