fix(*) rm work service in controller_test.go

k8s-ci-robot commented 4 years ago

Hi @leileiwan. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

leileiwan commented 4 years ago

for issue https://github.com/kubeflow/pytorch-operator/issues/228

coveralls commented 4 years ago

Coverage remained the same at 22.97% when pulling c0af20f90f6e9f6b4375e26e480d3993f7ab9f4c on leileiwan:master into edfcb53eb2af39b17093637f5e219105ac1324d6 on kubeflow:master.

johnugeorge commented 4 years ago

/ok-to-test

johnugeorge commented 4 years ago

/lgtm

johnugeorge commented 4 years ago

/approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)~~ [johnugeorge] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubeflow / pytorch-operator

fix(*) rm work service in controller_test.go #235