Closed leileiwan closed 4 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign gaocegege
You can assign the PR to them by writing /assign @gaocegege
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Hi @leileiwan. Thanks for your PR.
I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Is the change hand-written?
yes,I changed the function structFromUnstructured by myself
I think we should not update the vendor manually. When we use godep generate the vendor, the change will be overwritten.
I think we should not update the vendor manually. When we use godep generate the vendor, the change will be overwritten.
I know,but apimachinery seen to have a little bug. How can I better fix this bug in my own project ?
It is better to fix it upstream.
It is better to fix it upstream.
Ok,I wil close the PR
for issue https://github.com/kubeflow/pytorch-operator/issues/234