kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
306 stars 143 forks source link

Unstructured converted to Pytorch Job Anonymous field error when json uses inline mode #239

Closed leileiwan closed 4 years ago

leileiwan commented 4 years ago

for issue https://github.com/kubeflow/pytorch-operator/issues/234

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign gaocegege You can assign the PR to them by writing /assign @gaocegege in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 4 years ago

Hi @leileiwan. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 22.97% when pulling b7e2b13ed4d2872b934e5fb011147f49d95acfe2 on leileiwan:master into 26f9d0ce381fe50926741b776e8a3f73bd77640d on kubeflow:master.

leileiwan commented 4 years ago

Is the change hand-written?

yes,I changed the function structFromUnstructured by myself

gaocegege commented 4 years ago

I think we should not update the vendor manually. When we use godep generate the vendor, the change will be overwritten.

leileiwan commented 4 years ago

I think we should not update the vendor manually. When we use godep generate the vendor, the change will be overwritten.

I know,but apimachinery seen to have a little bug. How can I better fix this bug in my own project ?

johnugeorge commented 4 years ago

It is better to fix it upstream.

leileiwan commented 4 years ago

It is better to fix it upstream.

Ok,I wil close the PR