search

kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
306 stars 143 forks source link

v1beta foldeer has been renamed to v1 so needs the path too #243

Open MATRIX4284 opened 4 years ago

MATRIX4284 commented 4 years ago

v1beta foldeer has been renamed to v1 so needs the path too: new command: kubectl create -f ./v1/pytorch_job_mnist_gloo.yaml

Inconsistent documentation

k8s-ci-robot commented 4 years ago

Hi @MATRIX4284. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 22.97% when pulling 5719fb90f2fdc002b273e14f1734fcc8eb48aad0 on MATRIX4284:patch-1 into f117363c81dc51d5407ea40a3affe1c6eadd2477 on kubeflow:master.

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)~~ [gaocegege] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
MATRIX4284 commented 4 years ago

is this pr getting merged?

gaocegege commented 3 years ago

/retest

Jeffwan commented 3 years ago

@MATRIX4284 Can you rebase master changes? We recently update test pipeline. Once rebase is done, test should pass

aws-kf-ci-bot commented 3 years ago

@MATRIX4284: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pytorch-operator-presubmit-e2e 5719fb90f2fdc002b273e14f1734fcc8eb48aad0 link /test kubeflow-pytorch-operator-presubmit-e2e
kubeflow-pytorch-operator-presubmit 5719fb90f2fdc002b273e14f1734fcc8eb48aad0 link /test kubeflow-pytorch-operator-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).