search

kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
306 stars 143 forks source link

Updated the usrer steps necessary to run the out of the box #244

Closed MATRIX4284 closed 4 years ago

MATRIX4284 commented 4 years ago

image name gcr.io//pytorch_dist_mnist:latest wil cause the image pull to fail in case of non gcp users. So included the yaml specs with the local image i.e. kubeflow/pytorch-dist-mnist-test:1.0.

k8s-ci-robot commented 4 years ago

Hi @MATRIX4284. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign johnugeorge You can assign the PR to them by writing /assign @johnugeorge in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 22.97% when pulling 0a7e04f9ad5db107dc78f6e4f7a3654839738962 on MATRIX4284:master into f117363c81dc51d5407ea40a3affe1c6eadd2477 on kubeflow:master.

gaocegege commented 4 years ago

/ok-to-test

k8s-ci-robot commented 4 years ago

@MATRIX4284: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-pytorch-operator-presubmit 0a7e04f9ad5db107dc78f6e4f7a3654839738962 link /test kubeflow-pytorch-operator-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
MATRIX4284 commented 4 years ago

Added the required Dockerfile For mitigating the issue #245