kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
307 stars 143 forks source link

published thr pytorch docker as pytorch/pytorch:1.2-cuda10.0-cudnn7-runtime docker unable to use gpu #247

Closed MATRIX4284 closed 4 years ago

MATRIX4284 commented 4 years ago

published thr pytorch docker as pytorch/pytorch:1.2-cuda10.0-cudnn7-runtime docker unable to use gpu as it does not contsain cuda so mnist example unable to use cuda using the image pytorch/pytorch:1.2-cuda10.0-cudnn7-runtime

k8s-ci-robot commented 4 years ago

Hi @MATRIX4284. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign gaocegege You can assign the PR to them by writing /assign @gaocegege in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
MATRIX4284 commented 4 years ago

reopened as mistakenly closed

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 22.97% when pulling 59a37ce37161bccac0cedf689dc3b335b00fd45a on MATRIX4284:master into f117363c81dc51d5407ea40a3affe1c6eadd2477 on kubeflow:master.

johnugeorge commented 4 years ago

Why is the Dockerfile deleted?

MATRIX4284 commented 4 years ago

It was having additional pkgs which are not needed so it was deleted and replaced with a lightweight one

On Fri, 3 Jan 2020 at 11:02 AM, Johnu George notifications@github.com wrote:

Why is the Dockerfile deleted?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/kubeflow/pytorch-operator/pull/247?email_source=notifications&email_token=AE7YQABPWMFFJECBZ66ABGLQ33EVFA5CNFSM4KCFFU4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIAKLZA#issuecomment-570467812, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE7YQAECT72T2ZBVZ5KLFNTQ33EVFANCNFSM4KCFFU4A .

-- Thanks & Regards, Kaustav Technical Envagelist Embedded & Distributed Systems

MATRIX4284 commented 4 years ago

Why is the Dockerfile deleted?

Sorry i think it is a mistake...i will take a fresh checkout and merge my changes.Closing this PR and thanks for the review.