search

kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
306 stars 143 forks source link

Updated the GPU compatible Docker builiding porcess with the Kubeflow… #257

Open MATRIX4284 opened 4 years ago

MATRIX4284 commented 4 years ago

… provided pytorch Docker Image provided in PR #255

Updated the GPU compatible Docker builiding porcess with the Kubeflow provided pytorch Docker Image

k8s-ci-robot commented 4 years ago

Hi @MATRIX4284. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
coveralls commented 4 years ago

Coverage Status

Coverage increased (+41.1%) to 64.11% when pulling e5c0342b2ae7bf4609b3aba39ac24f74ae25406f on MATRIX4284:patch-2 into 047cf0f41e68e030158f532017a226c18827a660 on kubeflow:master.

PatrickXYS commented 3 years ago

/test ?

Is this PR still needed?

aws-kf-ci-bot commented 3 years ago

@PatrickXYS: The following commands are available to trigger jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/kubeflow/pytorch-operator/pull/257#issuecomment-733166740): >/test ? > >Is this PR still needed? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Jeffwan commented 3 years ago

@PatrickXYS yes. I will commit Ce's suggestion and approve this change

google-cla[bot] commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MATRIX4284 To complete the pull request process, please assign gaocegege after the PR has been reviewed. You can assign the PR to them by writing /assign @gaocegege in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-cla[bot] commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.