search

kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
306 stars 143 forks source link

pin kubenertes client version to work around a bug #262

Closed jinchihe closed 4 years ago

jinchihe commented 4 years ago

There is a problem in new kubenertes Client v11.0.0: https://github.com/kubernetes-client/python/issues/1112

The PR is going to pin the kubenertes Client to 10.0.1 to avoid the issue. Thanks

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 22.97% when pulling 858ba630ad301747e92be6301dbc86e5bc5871f3 on jinchihe:pin_k8s_version into 047cf0f41e68e030158f532017a226c18827a660 on kubeflow:master.

gaocegege commented 4 years ago

/lgtm /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[sdk/python/OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/sdk/python/OWNERS)~~ [gaocegege] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jinchihe commented 4 years ago

/retest

omlomloml commented 3 years ago

I still have this issue with kubenertes Client at latest 12.0