search

kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
306 stars 143 forks source link

Migrate pytorch-operator to go modules #272

Closed Jeffwan closed 4 years ago

Jeffwan commented 4 years ago
  1. Update the project to use go modules
  2. Bump Kubernetes dependencies to 1.15.9 (which is the version k8s use go modules)
  3. Update update-codegen.sh, .travis.yml and Dockerfile

I will file a PR to remove vendor directory separately. Otherwise, it makes PR hard to review.

Jeffwan commented 4 years ago

Seem presubmit test failed due to some dependency issues. The errors happens in test/e2e folder. I update vendor modules at this moment. While, the goal is to remove all vendor files.

johnugeorge commented 4 years ago

/approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)~~ [johnugeorge] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment