Open Jeffwan opened 4 years ago
Issue-Label Bot is automatically applying the labels:
Label | Probability |
---|---|
kind/feature | 0.75 |
Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.
SGTM.
/cc @johnugeorge wait for confirmation
Sorry for being late. SGTM. Lets do a release
Tensorflow and PyTorch uses branches rather than tags for dependency management. Since we may make some breaking changes in the repo. I would suggest to cut a release and tags as well.
My proposed change is
v0.7.0 release - https://github.com/kubeflow/pytorch-operator/commit/6097519829bea048dad541b8b506366263ecd1e8
This is last change in v0.7-branch.
v1.0.0 release - https://github.com/kubeflow/pytorch-operator/commit/047cf0f41e68e030158f532017a226c18827a660
This is actually the last change in v1.1-branch. While tf-operator and pytorch-operator has been graduated to v1 in July 2019 along with Kubeflow 0.7.0. I think it's better to have similar release cycle and naming as Kubeflow.
Kubeflow/common migration can be a v1.1.0 release candidate.
@johnugeorge @gaocegege @andreyvelich
I can help cut tag and release. Let me know if this makes sense.