search

kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
306 stars 143 forks source link

Update openapi-gen to not rely on vendor #274

Closed Jeffwan closed 4 years ago

Jeffwan commented 4 years ago
  1. Update gen-sdk.sh to use kube-openapi from go modules rather than vendor. Not all code-generator has /cmd/openapi-gen, 1.15 doesn't while it's added back in 1.16. Let's use kube-openapi here.
  2. central.maven.org is not resolvable on my end, seems it's http legacy url. Update the jar url and points to repo1.maven.org
Jeffwan commented 4 years ago

@jinchihe Please have another check

jinchihe commented 4 years ago

/lgtm

@Jeffwan Thanks!

Jeffwan commented 4 years ago

/cc @johnugeorge @gaocegege

johnugeorge commented 4 years ago

Sorry for being late /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)~~ [johnugeorge] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Jeffwan commented 4 years ago

/test kubeflow-pytorch-operator-presubmit

Jeffwan commented 4 years ago

Test failure is probably related with disk out of capacity failure.