search

kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
306 stars 143 forks source link

Fix minor OpenShift issues - resource requests, Dockerfile #276

Closed vpavlin closed 4 years ago

vpavlin commented 4 years ago

Hi, I'd like to propose these three changes to get pytorch operator and example working on OpenShift

The Dockerfile change is required because containers run as non-root user in OpenShift and the mnist.py needs to create some directories and files

The config.go is necessary because OpenShift has some minimial values set so we need to get over those values.

The rbac.yaml adds a missing resource which is needed in OpenShift to successfully operate the CRs

johnugeorge commented 4 years ago

/approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)~~ [johnugeorge] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment