search

kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
306 stars 143 forks source link

fix Dockerfile-mpi download miniconda.sh #277

Closed jiaqianjing closed 4 years ago

jiaqianjing commented 4 years ago

(curl -o -O) it's not work when I built image of mpi at aliyun

k8s-ci-robot commented 4 years ago

Hi @jiaqianjing. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
johnugeorge commented 4 years ago

/ok-to-test

gaocegege commented 4 years ago

Can you show us more info about it? Will it return an error?

jiaqianjing commented 4 years ago

Can you show us more info about it? Will it return an error?

image

jiaqianjing commented 4 years ago

And another question when I built image for mpi: image

gaocegege commented 4 years ago

/lgtm

johnugeorge commented 4 years ago

/approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)~~ [johnugeorge] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
gaocegege commented 4 years ago

@jiaqianjing Thanks for your contribution! :tada: :+1: