search

kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
306 stars 143 forks source link

Migrate code implementation to kubeflow/common fashion #282

Open Jeffwan opened 4 years ago

Jeffwan commented 4 years ago

kubeflow/common release a stable version 0.3.1 and we can migrate to use implementation of kubeflow/common.

The change will be similar to change https://github.com/kubeflow/tf-operator/pull/1171.

It would be better to resolve dependencies, upgrade to 0.3.1 for interfaces, and then update implementation.

Hope this can be part of 1.1 release.

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/feature 0.98

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.

johnugeorge commented 4 years ago

I am worried if it is little late for the 1.1 release. TF-operator one too has not been tested extensively with common.

Jeffwan commented 4 years ago

@johnugeorge Yeah, If we can not catch 1.1 release, I think we can postpone to next release. As TF and Pytorch already graduate to v1, we definitely need more test to avoid regression issues.