kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
306 stars 143 forks source link

Do we need pod name and namespace in manifests? #283

Open gaocegege opened 4 years ago

gaocegege commented 4 years ago

https://github.com/kubeflow/pytorch-operator/blob/master/manifests/deployment.yaml#L22

I think we can remove it.

/cc @johnugeorge

WDYT, I think we do not use it

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/question 0.78
area/operator 0.66

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.

jiaqianjing commented 4 years ago

watch