Closed jiaqianjing closed 4 years ago
/ok-to-test
/assign @johnugeorge
Can you please explain more about why we need the PR?
/ok-to-test
/assign @johnugeorge
Can you please explain more about why we need the PR?
SGTM
Can you add corresponding test for the new feature?
Can you add corresponding test for the new feature?
PTAL @jinchihe @andreyvelich
/assign @johnugeorge
Thanks for your contribution! :tada: :+1:
/approve
@johnugeorge @andreyvelich They need this feature urgently thus I am merging it. If you have any comment feel free to leave. We can fix in another PR.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gaocegege
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Hi @jiaqianjing. Thanks for your PR.
I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with
/ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.Once the patch is verified, the new status will be reflected by the
ok-to-test
label.I understand the commands that are listed here.