Support manifest on Kubernetes 1.16+

Jeffwan commented 4 years ago

Update Deployment apiVersion from extensions/v1beta1 to apps/v1

Jeffwan commented 4 years ago

/cc @jinchihe @andreyvelich

k8s-ci-robot commented 4 years ago

@Jeffwan: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
kubeflow-pytorch-operator-presubmit	af18022097391bb650c84c4fb5696beaacc8615d	link	`/test kubeflow-pytorch-operator-presubmit`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

Jeffwan commented 3 years ago

/cc @johnugeorge @gaocegege

Let's merge some pending PRs.

k8s-ci-robot commented 3 years ago

New changes are detected. LGTM label has been removed.

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jeffwan To complete the pull request process, please assign after the PR has been reviewed. You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

Jeffwan commented 3 years ago

PR https://github.com/kubeflow/pytorch-operator/pull/305 already includes this PR. I will close the issue

kubeflow / pytorch-operator

Support manifest on Kubernetes 1.16+ #301