search

kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
306 stars 143 forks source link

Make manifest test friendly #302

Closed Jeffwan closed 3 years ago

Jeffwan commented 4 years ago

Currently, it's using https://github.com/kubeflow/pytorch-operator/blob/61fefa88f75b126fd7672f44b87351db511299cb/scripts/setup-kubeflow.sh#L37 ksonnet manifest for PyTorch testing from v.0.7.0 tag.

it should use master manifest instead because if manifest needs a change, current testing can not support that case.

We already have /manifest and it just need some changes to have kustomization.yaml. Then we can easily replace image for testing purpose. manifest installation will use manifest from PR as well.

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/feature 0.94
area/engprod 0.57

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.

Jeffwan commented 3 years ago

Included in https://github.com/kubeflow/pytorch-operator/pull/305