search

kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
306 stars 143 forks source link

Add test friendly manifests #303

Closed Jeffwan closed 3 years ago

Jeffwan commented 4 years ago

Resolve #302

  1. We can use kubectl apply -k manifests/ to deploy pytorch-operator now.
  2. Images can be changed by following commands. 
kustomize edit set image gcr.io/kubeflow-images-public/pytorch-operator=${REGISTRY}/pytorch-operator:$(TAG)

This will be used to deprecate https://github.com/kubeflow/pytorch-operator/blob/master/scripts/setup-kubeflow.sh later.

test scripts will be in separate PR along with other changes

k8s-ci-robot commented 4 years ago

@Jeffwan: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pytorch-operator-presubmit b2becd6dc18dd5b83c462249fd7698c330e46930 link /test kubeflow-pytorch-operator-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
Jeffwan commented 3 years ago

/cc @johnugeorge @gaocegege

Let's merge some pending PRs.

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jeffwan To complete the pull request process, please assign johnugeorge after the PR has been reviewed. You can assign the PR to them by writing /assign @johnugeorge in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 64.11% when pulling c7b3709fb652c6a81e333271bf0baa5519094626 on Jeffwan:test_friendly_manifest into 3ae98080c0768c031dee986527389c05cfc09438 on kubeflow:master.

aws-kf-ci-bot commented 3 years ago

@Jeffwan: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pytorch-operator-presubmit c7b3709fb652c6a81e333271bf0baa5519094626 link /test kubeflow-pytorch-operator-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
Jeffwan commented 3 years ago

this https://github.com/kubeflow/pytorch-operator/pull/305 already include the changes. I will close this PR