search

kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
306 stars 143 forks source link

Move PyTorch Operator e2e tests to AWS Prow #305

Closed Jeffwan closed 3 years ago

PatrickXYS commented 3 years ago

/lgtm

Jeffwan commented 3 years ago

/retest

Jeffwan commented 3 years ago

/retest

Jeffwan commented 3 years ago

sdk test failure:

 ls /usr/local/lib/py*
/usr/local/lib/python3.6:
dist-packages

/usr/local/lib/python3.8:
dist-packages

table_logger actually is installed in 3.6. however, we have two python envs in the package and pytest use 3.8 which doesn't have dependency

Jeffwan commented 3 years ago

/test ?

aws-kf-ci-bot commented 3 years ago

@Jeffwan: The following commands are available to trigger jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/kubeflow/pytorch-operator/pull/305#issuecomment-711119240): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 3 years ago

@Jeffwan: The following commands are available to trigger jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/kubeflow/pytorch-operator/pull/305#issuecomment-711119240): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 3 years ago

@Jeffwan: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pytorch-operator-presubmit d13b055a8f7ca566c6f5fa63f024d84e031e06bf link /test kubeflow-pytorch-operator-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
PatrickXYS commented 3 years ago

/test ?

k8s-ci-robot commented 3 years ago

@PatrickXYS: No presubmit jobs available for kubeflow/pytorch-operator@master

In response to [this](https://github.com/kubeflow/pytorch-operator/pull/305#issuecomment-712214194): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
aws-kf-ci-bot commented 3 years ago

@PatrickXYS: The following commands are available to trigger jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/kubeflow/pytorch-operator/pull/305#issuecomment-712214194): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
PatrickXYS commented 3 years ago

@PatrickXYS: No presubmit jobs available for kubeflow/pytorch-operator@master

This still suffices even though we don't have Upstream Prow Prsubmit Enabled

PatrickXYS commented 3 years ago

/test presubmit-pytorch-e2e

k8s-ci-robot commented 3 years ago

@PatrickXYS: No presubmit jobs available for kubeflow/pytorch-operator@master

In response to [this](https://github.com/kubeflow/pytorch-operator/pull/305#issuecomment-712215073): >/test presubmit-pytorch-e2e Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
andreyvelich commented 3 years ago

@Jeffwan @PatrickXYS Can you add LGTM on this PR: https://github.com/kubeflow/pytorch-operator/pull/293, please? That should fix travis unit test.

Jeffwan commented 3 years ago

I think the only one left is we want aws-bot report test status on the PR. Besides that, everything looks good to me

andreyvelich commented 3 years ago

@Jeffwan Yes. Try to rebase to fix unit tests

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 64.11% when pulling 47054e566361826bdd2156189bb9d6058c51bc26 on Jeffwan:aws_test_infra into 3ae98080c0768c031dee986527389c05cfc09438 on kubeflow:master.

Jeffwan commented 3 years ago

/retest

PatrickXYS commented 3 years ago

/test ?

aws-kf-ci-bot commented 3 years ago

@PatrickXYS: The following commands are available to trigger jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/kubeflow/pytorch-operator/pull/305#issuecomment-714038246): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 3 years ago

@PatrickXYS: No presubmit jobs available for kubeflow/pytorch-operator@master

In response to [this](https://github.com/kubeflow/pytorch-operator/pull/305#issuecomment-714038246): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
PatrickXYS commented 3 years ago

/test presubmit-pytorch-e2e

Jeffwan commented 3 years ago

/test presubmit-pytorch-e2e

k8s-ci-robot commented 3 years ago

@PatrickXYS: No presubmit jobs available for kubeflow/pytorch-operator@master

In response to [this](https://github.com/kubeflow/pytorch-operator/pull/305#issuecomment-714038481): >/test presubmit-pytorch-e2e Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 3 years ago

@Jeffwan: No presubmit jobs available for kubeflow/pytorch-operator@master

In response to [this](https://github.com/kubeflow/pytorch-operator/pull/305#issuecomment-714038510): >/test presubmit-pytorch-e2e Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
PatrickXYS commented 3 years ago

/test?

aws-kf-ci-bot commented 3 years ago

@PatrickXYS: The following commands are available to trigger jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/kubeflow/pytorch-operator/pull/305#issuecomment-714062356): >/test? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 3 years ago

@PatrickXYS: No presubmit jobs available for kubeflow/pytorch-operator@master

In response to [this](https://github.com/kubeflow/pytorch-operator/pull/305#issuecomment-714062356): >/test? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
PatrickXYS commented 3 years ago

/test ?

aws-kf-ci-bot commented 3 years ago

@PatrickXYS: The following commands are available to trigger jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/kubeflow/pytorch-operator/pull/305#issuecomment-714062488): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 3 years ago

@PatrickXYS: No presubmit jobs available for kubeflow/pytorch-operator@master

In response to [this](https://github.com/kubeflow/pytorch-operator/pull/305#issuecomment-714062488): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Jeffwan commented 3 years ago

/cc @gaocegege @johnugeorge

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)~~ [gaocegege] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
gaocegege commented 3 years ago

/lgtm