search

kubeflow / pytorch-operator

PyTorch on Kubernetes
Apache License 2.0
306 stars 143 forks source link

Add Jeffwan@ to OWNERS #306

Closed Jeffwan closed 3 years ago

Jeffwan commented 3 years ago

I would like to add myself to approvers. I am working on kubeflow/common and other operators a lot and I am pretty familiar with the code base. Currently I am working on pytorch test infra migration and pytorch kubeflow/common migration. Hope to gain access to iterate faster.

Not that many PRs against PyTorch but I would like to contribute more. https://github.com/kubeflow/pytorch-operator/pulls/Jeffwan

/cc @johnugeorge @gaocegege

google-cla[bot] commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 64.11% when pulling f1d2e722ea30281734d91883bea7591a5d5fde6d on Jeffwan:add_approvers into d88cafecdf185e39318198327d8f49700bafacfa on kubeflow:master.

gaocegege commented 3 years ago

/approve

Thanks for your contribution! :tada: :+1:

k8s-ci-robot commented 3 years ago

@Jeffwan: No presubmit jobs available for kubeflow/pytorch-operator@master

In response to [this](https://github.com/kubeflow/pytorch-operator/pull/306#issuecomment-714172030): > >/test kubeflow-pytorch-operator-presubmit >-- > > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Jeffwan commented 3 years ago

/test kubeflow-pytorch-operator-presubmit

k8s-ci-robot commented 3 years ago

@Jeffwan: No presubmit jobs available for kubeflow/pytorch-operator@master

In response to [this](https://github.com/kubeflow/pytorch-operator/pull/306#issuecomment-714172073): >/test kubeflow-pytorch-operator-presubmit > > > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
PatrickXYS commented 3 years ago

I think you might need to first merge https://github.com/kubeflow/pytorch-operator/pull/305, then you can make the presubmit pass

Jeffwan commented 3 years ago

@PatrickXYS Right, I ask them to approve the PR and then I can do a rebase

johnugeorge commented 3 years ago

/approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, gaocegege, Jeffwan, johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)~~ [gaocegege,johnugeorge] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
PatrickXYS commented 3 years ago

/lgtm