Reuse Common Scripts for Creating / Deleting EKS clusters

kubeflow / pytorch-operator

PyTorch on Kubernetes

Apache License 2.0

306 stars 143 forks source link

Reuse Common Scripts for Creating / Deleting EKS clusters #308

Closed PatrickXYS closed 3 years ago

PatrickXYS commented 3 years ago

Reuse Common Scripts for Creating / Deleting EKS clusters will save efforts when clean-up EKS cluster resources

andreyvelich commented 3 years ago

I think you can remove create-cluster and delete-cluster scripts since we are not more using it.

PatrickXYS commented 3 years ago

I've noticed many times that Travis test got queued and stuck there, thus, I think now it becomes a bottleneck for test

coveralls commented 3 years ago

Coverage remained the same at 64.11% when pulling 1c13bb6a16364f188f84b4bdfd6592ee6bf37fcb on PatrickXYS:yao_aws_account into 518f9c764466dc699de9e835f51d8f6611f33db1 on kubeflow:master.

PatrickXYS commented 3 years ago

/cc @Jeffwan @andreyvelich Can you approve the PR since all the tests passed?

Jeffwan commented 3 years ago

/approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, Jeffwan, PatrickXYS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)~~ [Jeffwan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment