PyTorch Operator: Move manifests development upstream

kubeflow / pytorch-operator

PyTorch on Kubernetes

Apache License 2.0

307 stars 143 forks source link

PyTorch Operator: Move manifests development upstream #320

Closed yanniszark closed 3 years ago

yanniszark commented 3 years ago

Issue Resolved

Resolves: https://github.com/kubeflow/pytorch-operator/issues/318 Umbrella issue: https://github.com/kubeflow/manifests/issues/1740

Description

As part of the work of wg-manifests for 1.3 (https://github.com/kubeflow/manifests/issues/1735), we are moving manifests development in upstream repos. This gives the application developers full ownership of their manifests, tracked in a single place.

This PR copies the manifests for application PyTorch Operator from path apps/pytorch-job/upstream of kubeflow/manifests to path manifests of the upstream repo (https://github.com/kubeflow/pytorch-operator).

cc @kubeflow/wg-training-leads

coveralls commented 3 years ago

Coverage remained the same at 64.11% when pulling 6c21fec07436f71fab698bf776a188f71f3e1cc4 on arrikto:feature-move-pytorch-operator-manifests-upstream into 6293efc19503078953acf04df03a1204fd265e35 on kubeflow:master.

yanniszark commented 3 years ago

@terrytangyuan is there any work remaining for merging the PR?

terrytangyuan commented 3 years ago

I'd defer to @johnugeorge and others from @kubeflow/wg-training-leads to confirm since I didn't author these manifests originally.

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, terrytangyuan, yanniszark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/pytorch-operator/blob/master/OWNERS)~~ [Jeffwan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment