Truncate UI service name if over 63 characters

jacobsalway commented 2 weeks ago

Purpose of this PR

Truncate the UI service name while appending a hash to ensure uniqueness if longer than 63 characters.

Close https://github.com/kubeflow/spark-operator/issues/2300

Change Category

[X] Bugfix (non-breaking change which fixes an issue)
[ ] Feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that could affect existing functionality)
[ ] Documentation update

Checklist

[X] I have conducted a self-review of my own code.
[ ] I have updated documentation accordingly.
[X] I have added tests that prove my changes are effective or that my feature works.
[X] Existing unit tests pass locally with my changes.

jacobsalway commented 2 weeks ago

/assign @ChenYi015 @ImpSy

jacobsalway commented 6 days ago

Bumping since the comments were addressed.

ImpSy commented 4 days ago

/lgtm

ImpSy commented 4 days ago

@ChenYi015 can you approve this ?

google-oss-prow[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015, ImpSy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/spark-operator/blob/master/OWNERS)~~ [ChenYi015] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubeflow / spark-operator