search

kubeflow / training-operator

Distributed ML Training and Fine-Tuning on Kubernetes
https://www.kubeflow.org/docs/components/training
Apache License 2.0
1.6k stars 698 forks source link

Support CertManager for the Webhook cert generation #2049

Open tenzen-y opened 6 months ago

tenzen-y commented 6 months ago

/kind feature

Currently, the training-operator generates certs for the webhook using the internal cert generation mechanism for all installation ways.

However, we know that some administrators prefer to use the cert-manager to manage all certifications for security and so on. So, I would suggest supporting the cert generation mechanism by the cert-manager.

xref: #2035

tenzen-y commented 6 months ago

/kind feature

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

tenzen-y commented 3 months ago

/remove-lifecycle stale

andreyvelich commented 3 months ago

/good-first-issue

google-oss-prow[bot] commented 3 months ago

@andreyvelich: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubeflow/training-operator/issues/2049): >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tariq-hasan commented 2 months ago

/assign