search

kubeflow / training-operator

Distributed ML Training and Fine-Tuning on Kubernetes
https://www.kubeflow.org/docs/components/training
Apache License 2.0
1.61k stars 698 forks source link

chore(style): provide type for `STORAGE_INITIALIZER_VOLUME` constant #2093

Open PantherHawk opened 6 months ago

PantherHawk commented 6 months ago

what happened?

$ mypy mypy sdk/python/kubeflow/training/constants/constants.py | grep -i ":87"
sdk/python/kubeflow/training/constants/constants.py:87: error: Module has no attribute "V1Volume"  [attr-defined]

what did you expect? No style errors.

is there a fix? Maybe?

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

andreyvelich commented 3 months ago

Sorry for the late reply. @PantherHawk Any problems you see with that ? It should work since we import all models from Kubernetes: https://github.com/kubeflow/training-operator/blob/master/sdk/python/kubeflow/training/models/__init__.py#L17

github-actions[bot] commented 2 weeks ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.