Refine the integration tests for the immutable PyTorchJob queueName

kubeflow / training-operator

Distributed ML Training and Fine-Tuning on Kubernetes

https://www.kubeflow.org/docs/components/training

Apache License 2.0

1.51k stars 660 forks source link

Refine the integration tests for the immutable PyTorchJob queueName #2130

Closed tenzen-y closed 1 month ago

tenzen-y commented 1 month ago

What this PR does / why we need it: I refined the integration tests for the PyTorchJob queueName. By passing the root Gomega instance, the Gomega could clarify the reason for the test failure.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged): Follow-up #2079

Checklist:

[ ] Docs included if any changes are user facing

tenzen-y commented 1 month ago

/assign @johnugeorge @andreyvelich

cc: @ckyuto

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9297425549

Details

0 of 0 changed or added relevant lines in 0 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.04%) to 35.414%

Files with Coverage Reduction	New Missed Lines	%
pkg/controller.v1/mpi/mpijob.go	1	91.06%
pkg/controller.v1/mpi/mpijob_controller.go	2	81.24%
<!--	Total:	3	-->

Totals
Change from base Build 9297317363:	0.04%
Covered Lines:	4379
Relevant Lines:	12365

💛 - Coveralls

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/training-operator/blob/master/OWNERS)~~ [andreyvelich] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment