kubeflow / training-operator

Distributed ML Training and Fine-Tuning on Kubernetes
https://www.kubeflow.org/docs/components/training
Apache License 2.0
1.51k stars 660 forks source link

Automated cherry pick of #2079: fix volcano podgroup update issue #2136

Closed tenzen-y closed 3 weeks ago

tenzen-y commented 3 weeks ago

Cherry pick of #2079 on v1.8-branch.

2079: fix volcano podgroup update issue

For details on the cherry pick process, see the cherry pick requests page.

google-oss-prow[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from tenzen-y. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/training-operator/blob/v1.8-branch/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tenzen-y commented 3 weeks ago

/close

google-oss-prow[bot] commented 3 weeks ago

@tenzen-y: Closed this PR.

In response to [this](https://github.com/kubeflow/training-operator/pull/2136#issuecomment-2155094795): >/close > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tenzen-y commented 3 weeks ago

/reopen

google-oss-prow[bot] commented 3 weeks ago

@tenzen-y: Reopened this PR.

In response to [this](https://github.com/kubeflow/training-operator/pull/2136#issuecomment-2155095754): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 9419664408

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller.v1/common/job.go 0 3 0.0%
<!-- Total: 0 3 0.0% -->
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob.go 1 91.06%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 8869266420: -0.02%
Covered Lines: 4373
Relevant Lines: 12365

💛 - Coveralls