kubeflow / training-operator

Distributed ML Training and Fine-Tuning on Kubernetes

https://www.kubeflow.org/docs/components/training

Apache License 2.0

1.51k stars 660 forks source link

Automated cherry pick of #2079: fix volcano podgroup update issue #2130: Refine the integration tests for the immutable PyTorchJob #2139

Closed tenzen-y closed 3 weeks ago

tenzen-y commented 3 weeks ago

Cherry pick of #2079 #2130 on v1.8-branch.

2079: fix volcano podgroup update issue

2130: Refine the integration tests for the immutable PyTorchJob

I manually squashed commits and modified signs since @ckyuto signed to DCO and CLA with different email addresses.

Commit sha: 18844bd, Author: Weiyu Yen, Committer: Yuki Iwai; Expected "Weiyu Yen wyen@linkedin.com", but got "Weiyu Yen ckyuto@gmail.com".

https://github.com/kubeflow/training-operator/pull/2134/checks?check_run_id=25949083128

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 9419698397

Details

0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.03%) to 35.414%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/controller.v1/common/job.go	0	3	0.0%
<!--	Total:	0	3	0.0%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/controller.v1/mpi/mpijob.go	1	91.06%
<!--	Total:	1		-->

Totals
Change from base Build 8869266420:	0.03%
Covered Lines:	4379
Relevant Lines:	12365

Pull Request Test Coverage Report for Build 9419796281

Details

0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.03%) to 35.414%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/controller.v1/common/job.go	0	3	0.0%
<!--	Total:	0	3	0.0%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/controller.v1/mpi/mpijob.go	1	91.06%
<!--	Total:	1		-->

Totals
Change from base Build 8869266420:	0.03%
Covered Lines:	4379
Relevant Lines:	12365

💛 - Coveralls

google-oss-prow[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/training-operator/blob/v1.8-branch/OWNERS)~~ [andreyvelich] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment