search

kubeflow / training-operator

Distributed ML Training and Fine-Tuning on Kubernetes
https://www.kubeflow.org/docs/components/training
Apache License 2.0
1.61k stars 698 forks source link

Improve Training Operator release process #2155

Open andreyvelich opened 4 months ago

andreyvelich commented 4 months ago

Related: https://github.com/kubeflow/katib/issues/2049

We need to improve our release process for Training Operator:

/good-first-issue /help

google-oss-prow[bot] commented 4 months ago

@andreyvelich: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubeflow/training-operator/issues/2155): >Related: https://github.com/kubeflow/katib/issues/2049 > >We need to improve our release process for Training Operator: > >- Branch names should follow this pattern: `release-X.Y`. Similar to Katib or Kubernetes. >- Automate release with GitHub Actions. > >/good-first-issue >/help > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
7h3-3mp7y-m4n commented 4 months ago

I want to take this. /assign

tenzen-y commented 3 months ago

Additionally, I would like to use the semantic versioning image tags every for the release here: https://github.com/kubeflow/training-operator/blob/f8687ca7fd947e6ebd52dde4dfeefdf006e7b239/manifests/overlays/standalone/kustomization.yaml#L9

7h3-3mp7y-m4n commented 3 months ago

okay I'll look at it and raise a PR ASAP

Deathfireofdoom commented 2 weeks ago

No one is working on this one right? I can take a look /assign

tenzen-y commented 2 weeks ago

No one is working on this one right? I can take a look /assign

Yes, feel free to take this.

andreyvelich commented 2 weeks ago

Thank you for your time @Deathfireofdoom! I would also suggest to also check how we refactor and automate the Spark Operator release process with @ChenYi015 : https://github.com/kubeflow/spark-operator/pull/2089

I think, we can re-use some of the steps.